Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

There are pull requests from May that haven't been even answered or commented. Am I wrong, or shouldn't it be a custom to at least comment why you're not including it into the code?


No reply most of the times is received as a "I don't care" message by the PR author, while it is almost always lack of time to reply by the project maintainer.


You are right :( I want to review all pull request with careful, It implies a lot of code and I need find the time.


Just tell them that then... no harm in being straightforward.


This is good advice. I used to help maintain a bit on the bigger size project on Github and our lead developer I think really wanted to spend time looking over and trying to give quality responses. Which ended up sometimes taking a long time or not at all. Unfortunately, it came off to some people as not caring about their submissions. Just a simple message about being busy and asking them to remind you if you forget works wonders.

Example: "Thanks for sending this in. I'm busy right now but will look into it later. If I haven't responded in a week or two, do me a favor and ping this thread."




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: